User talk:Krinkle: Difference between revisions

Browse history interactively

← Older edit Newer edit →

Content deleted Content added

VisualWikitext

Inline

Revision as of 18:36, 2 September 2012

Welcome to the Wikimedia Foundation Governance Wiki Editors Group

Thanks for being here!

If you have not already, please:

Review the expectations of editor group accounts
Review the wiki's Manual of style
Join the internal #governance-wiki Slack channel for this wiki

Please contact the wiki's core administrators team with questions, problems, or for assistance.

Thank you in advance for your contributions to this wiki and for respecting its policies, guidelines, and procedures.

-~~~~ on behalf of the Wikimedia Foundation Governance Wiki Core Administrators Team PeterSymonds (talk) 19:58, 19 June 2012 (UTC)[reply]

Template:Staff and contractors

Hi. When I click "collapse all departments" at <https://wikimediafoundation.org/wiki/Template:Staff_and_contractors?showall=1>, I'm taken to <https://wikimediafoundation.org/wiki/Template:Staff_and_contractors?showall=undefined>. The URL is funky, but the functionality seems to be working as expected. --MZMcBride (talk) 04:35, 27 August 2012 (UTC)[reply]

Thanks, fixed. It now omits "showall" from the url instead of setting it to false or undefined. URL is much cleaner now. Krinkle (talk) 16:23, 27 August 2012 (UTC)[reply]

You're wonderful. Thank you for the quick fix! --MZMcBride (talk) 21:23, 27 August 2012 (UTC)[reply]

The expand/collapse all functionality is now broken again. I think it's due to the jQuery upgrade from last week. Can you please take a look at the page when you have a minute? The JavaScript console shows the relevant error/issue (something about "span#expand-all"), but I can't figure out the exact cause of the problem. --MZMcBride (talk) 04:01, 2 September 2012 (UTC)[reply]

Fixed in this edit. It appears the Expand.js plugin was building a CSS selector that included literal surrounding quotes inside the string (e.g. selector = "'foobar:first'";) which is obviously invalid and never worked (not now, not before). However previously Sizzle (jQuery's selector engine) would just silently fail, and now it throw an exception (as it should). Fixed now. Krinkle (talk) 18:30, 2 September 2012 (UTC)[reply]

Thanks again for your help with this! --MZMcBride (talk) 18:36, 2 September 2012 (UTC)[reply]

@@ Line 9: / Line 9: @@
 The expand/collapse all functionality is now broken again. I think it's due to the jQuery upgrade from last week. Can you please take a look at the page when you have a minute? The JavaScript console shows the relevant error/issue (something about "span#expand-all"), but I can't figure out the exact cause of the problem. --[[User:MZMcBride|MZMcBride]] ([[User talk:MZMcBride|talk]]) 04:01, 2 September 2012 (UTC)
 :Fixed in [https://wikimediafoundation.org/w/index.php?title=MediaWiki:Expand.js&diff=prev&oldid=83460 this edit]. It appears the Expand.js plugin was building a CSS selector that included literal surrounding quotes inside the string (e.g. <code>selector = "'foobar:first'";</code>) which is obviously invalid and never worked (not now, not before). However previously Sizzle (jQuery's selector engine) would just silently fail, and now it throw an exception (as it should). Fixed now. [[User:Krinkle|Krinkle]] ([[User talk:Krinkle|talk]]) 18:30, 2 September 2012 (UTC)
+:: Thanks again for your help with this! --[[User:MZMcBride|MZMcBride]] ([[User talk:MZMcBride|talk]]) 18:36, 2 September 2012 (UTC)