User talk:Krinkle

From Wikimedia Foundation Governance Wiki
Revision as of 12:15, 10 September 2012 by Meno25 (talk | contribs) (subst)

PeterSymonds (talk) 19:58, 19 June 2012 (UTC)[reply]

Hi. When I click "collapse all departments" at <https://wikimediafoundation.org/wiki/Template:Staff_and_contractors?showall=1>, I'm taken to <https://wikimediafoundation.org/wiki/Template:Staff_and_contractors?showall=undefined>. The URL is funky, but the functionality seems to be working as expected. --MZMcBride (talk) 04:35, 27 August 2012 (UTC)[reply]

Thanks, fixed. It now omits "showall" from the url instead of setting it to false or undefined. URL is much cleaner now. Krinkle (talk) 16:23, 27 August 2012 (UTC)[reply]
You're wonderful. Thank you for the quick fix! --MZMcBride (talk) 21:23, 27 August 2012 (UTC)[reply]

The expand/collapse all functionality is now broken again. I think it's due to the jQuery upgrade from last week. Can you please take a look at the page when you have a minute? The JavaScript console shows the relevant error/issue (something about "span#expand-all"), but I can't figure out the exact cause of the problem. --MZMcBride (talk) 04:01, 2 September 2012 (UTC)[reply]

Fixed in this edit. It appears the Expand.js plugin was building a CSS selector that included literal surrounding quotes inside the string (e.g. selector = "'foobar:first'";) which is obviously invalid and never worked (not now, not before). However previously Sizzle (jQuery's selector engine) would just silently fail, and now it throw an exception (as it should). Fixed now. Krinkle (talk) 18:30, 2 September 2012 (UTC)[reply]
Thanks again for your help with this! --MZMcBride (talk) 18:36, 2 September 2012 (UTC)[reply]
"Thanks for using Krinkle Services" :) Krinkle (talk) 19:29, 2 September 2012 (UTC)[reply]