User talk:Krinkle

From Wikimedia Foundation Governance Wiki
Revision as of 21:10, 24 March 2013 by MZMcBride (talk | contribs) (→‎Collapse code: new section)

Latest comment: 11 years ago by MZMcBride in topic Collapse code

PeterSymonds (talk) 19:58, 19 June 2012 (UTC)Reply

Template:Staff and contractors

Hi. When I click "collapse all departments" at <https://wikimediafoundation.org/wiki/Template:Staff_and_contractors?showall=1>, I'm taken to <https://wikimediafoundation.org/wiki/Template:Staff_and_contractors?showall=undefined>. The URL is funky, but the functionality seems to be working as expected. --MZMcBride (talk) 04:35, 27 August 2012 (UTC)Reply

Thanks, fixed. It now omits "showall" from the url instead of setting it to false or undefined. URL is much cleaner now. Krinkle (talk) 16:23, 27 August 2012 (UTC)Reply
You're wonderful. Thank you for the quick fix! --MZMcBride (talk) 21:23, 27 August 2012 (UTC)Reply

The expand/collapse all functionality is now broken again. I think it's due to the jQuery upgrade from last week. Can you please take a look at the page when you have a minute? The JavaScript console shows the relevant error/issue (something about "span#expand-all"), but I can't figure out the exact cause of the problem. --MZMcBride (talk) 04:01, 2 September 2012 (UTC)Reply

Fixed in this edit. It appears the Expand.js plugin was building a CSS selector that included literal surrounding quotes inside the string (e.g. selector = "'foobar:first'";) which is obviously invalid and never worked (not now, not before). However previously Sizzle (jQuery's selector engine) would just silently fail, and now it throw an exception (as it should). Fixed now. Krinkle (talk) 18:30, 2 September 2012 (UTC)Reply
Thanks again for your help with this! --MZMcBride (talk) 18:36, 2 September 2012 (UTC)Reply
"Thanks for using Krinkle Services" :) Krinkle (talk) 19:29, 2 September 2012 (UTC)Reply

Collapse code

Hi. The show/hide functionality at User:Thehelpfulone/Fundraising wasn't working properly (there was an error in the JavaScript console about missing collapseTable). So I copied over some relevant code from w:en:MediaWiki:Common.js to MediaWiki:Common.js, but this led to two show/hide links. Consequently, I disabled the legacy collapsible tables gadget for now, as a temporary measure, as it was not working and the code from the English Wikipedia was working. User:Thehelpfulone/Fundraising now functions properly. I didn't have the patience to debug the issue properly, but if you do, please feel free to undo any mess I may have made. --MZMcBride (talk) 21:10, 24 March 2013 (UTC)Reply